Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/jaeger] Adding agent sidecar for query and OWNERS file, update jaeger to 1.12 #13693

Merged
merged 4 commits into from
May 30, 2019
Merged

[incubator/jaeger] Adding agent sidecar for query and OWNERS file, update jaeger to 1.12 #13693

merged 4 commits into from
May 30, 2019

Conversation

naseemkullah
Copy link
Collaborator

@naseemkullah naseemkullah commented May 10, 2019 •
edited
Loading

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • title of the PR contains starts with chart name e.g. [stable/chart]

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @naseemkullah. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2019
@naseemkullah
Copy link
Collaborator Author

bump

@naseemkullah
Update to 1.12.0
48a7026 
Signed-off-by: Naseem <[email protected]>
@naseemkullah naseemkullah mentioned this pull request May 30, 2019
Closed
@maorfr
Copy link
Member

maorfr commented May 30, 2019

/assign
/ok-to-test

please add yourselves to the Chart.yaml file as well :)

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2019
@naseemkullah naseemkullah mentioned this pull request May 30, 2019
Open
@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 30, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label May 30, 2019
@naseemkullah naseemkullah changed the title [incubator/jaeger] Adding agent sidecar for query and OWNERS file [incubator/jaeger] Adding agent sidecar for query and OWNERS file, update jaeger to 1.12 May 30, 2019
@maorfr
Copy link
Member

maorfr commented May 30, 2019

/lgtm

thanks and good luck!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maorfr, naseemkullah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@naseemkullah
Copy link
Collaborator Author

Thanks @maorfr !

@k8s-ci-robot k8s-ci-robot merged commit d51308f into helm:master May 30, 2019
rvdh pushed a commit to rvdh/charts that referenced this pull request Jun 3, 2019
@naseemkullah @rvdh
[incubator/jaeger] Adding agent sidecar for query and OWNERS file, up…
2bb7e33 
…date jaeger to 1.12 (helm#13693)

* Add optional agent sidecar to query

Signed-off-by: Naseem <[email protected]>

* Adding OWNERS file and various

Signed-off-by: Naseem <[email protected]>

* Update to 1.12.0

Signed-off-by: Naseem <[email protected]>

* Add myself to Chart.yaml

Signed-off-by: Naseem <[email protected]>
davidkarlsen pushed a commit to davidkarlsen/charts that referenced this pull request Jun 5, 2019
@naseemkullah @davidkarlsen
[incubator/jaeger] Adding agent sidecar for query and OWNERS file, up…
5011fae 
…date jaeger to 1.12 (helm#13693)

* Add optional agent sidecar to query

Signed-off-by: Naseem <[email protected]>

* Adding OWNERS file and various

Signed-off-by: Naseem <[email protected]>

* Update to 1.12.0

Signed-off-by: Naseem <[email protected]>

* Add myself to Chart.yaml

Signed-off-by: Naseem <[email protected]>
@naseemkullah naseemkullah deleted the jaeger-sidecar branch July 14, 2019 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

@scottrigby scottrigby Awaiting requested review from scottrigby

Assignees

@maorfr maorfr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naseemkullah @k8s-ci-robot @maorfr @helm-bot