Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improving godoc #95

Merged
merged 3 commits into from
Mar 12, 2018
Merged

improving godoc #95

merged 3 commits into from
Mar 12, 2018

Conversation

rafaeljesus
Copy link
Contributor

  • Improve godoc
  • Improve error handling
  • Rename some variables

@rafaeljesus rafaeljesus self-assigned this Mar 10, 2018
@rafaeljesus rafaeljesus requested a review from italolelis March 10, 2018 09:22
@rafaeljesus rafaeljesus force-pushed the feature/docs-improvements branch from e8ae433 to e0b790c Compare March 10, 2018 09:22
@codecov
Copy link

codecov bot commented Mar 10, 2018 •
edited
Loading

Codecov Report

Merging #95 into master will decrease coverage by 0.3%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   32.39%   32.09%   -0.31%     
==========================================
  Files           5        5              
  Lines         213      215       +2     
==========================================
  Hits           69       69              
- Misses        140      142       +2     
  Partials        4        4
Impacted Files Coverage Δ
pkg/anonymiser/anonymiser.go 69.76% <ø> (ø) ⬆️
pkg/dumper/query/writer.go 66.66% <ø> (ø) ⬆️
pkg/dumper/query/dumper.go 0% <0%> (ø) ⬆️
pkg/dsn/dsn.go 49.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbca864...5c17dbc. Read the comment docs.

@rafaeljesus rafaeljesus requested a review from vgarvardt March 11, 2018 06:47
@aleksandrzhiliaev
Copy link

+1

@rafaeljesus rafaeljesus merged commit 1a15196 into master Mar 12, 2018
@rafaeljesus rafaeljesus deleted the feature/docs-improvements branch March 12, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandrzhiliaev aleksandrzhiliaev aleksandrzhiliaev approved these changes

@italolelis italolelis italolelis approved these changes

@vgarvardt vgarvardt Awaiting requested review from vgarvardt

Assignees

@rafaeljesus rafaeljesus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaeljesus @aleksandrzhiliaev @italolelis