-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Update #94
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 32.39% 32.39%
=======================================
Files 5 5
Lines 213 213
=======================================
Hits 69 69
Misses 140 140
Partials 4 4 Continue to review full report at Codecov.
|
README.md
Outdated
@@ -56,7 +107,25 @@ klepto steal \ | |||
--read-max-conns=8 | |||
``` | |||
|
|||
## Relationships | |||
Behind the scenes Klepto will establishes the connection with the source and target databases with the given parameters passed, and will dump 4 the tables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaeljesus Is this description correct for the example file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I just realised that for this particular example we don't need to set
--concurrency
--read-max-conns
--read-max-idle-conns
Given this config only dumps a single table (users). We could move them to the recommend section
below I think
README.md
Outdated
You can set the following fields in the file: | ||
* Tables | ||
* Matchers | ||
* more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rafaeljesus What other fields can you set in the toml file, and what do they mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tables
represents table definitionFilters
represents the way you want to filter the resultsMatchers
are variables to replace placeholders in FilterRelationships
represents a relationship definition
README.md
Outdated
## Relationships | ||
Behind the scenes Klepto will establishes the connection with the source and target databases with the given parameters passed, and will dump 4 the tables. | ||
|
||
We recommend to always set the following parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
@julyate thanks a lot |
No description provided.