Allow cancelation of long queries #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeljesus
force-pushed
the
feature/allow-cancelation-long-queries
branch
from
a3f5107 to
957a013
Compare
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 32.39% 32.39%
=======================================
Files 5 5
Lines 213 213
=======================================
Hits 69 69
Misses 140 140
Partials 4 4Continue to review full report at Codecov.
|
vgarvardt
reviewed
Mar 6, 2018
pkg/reader/mysql/reader.go
Outdated
| @@ -17,8 +17,8 @@ type storage struct { | |||
| } | |||
|
|
|||
| // NewStorage ... | |||
| func NewStorage(conn *sql.DB) reader.Reader { | |||
| return generic.NewSqlReader(&storage{conn}) | |||
| func NewStorage(conn *sql.DB, t time.Duration) reader.Reader { | |||
There was a problem hiding this comment.
IMO t is too implicit and tells only aboit the type, but not the purpose of the parameter
pkg/reader/postgres/reader.go
Outdated
| connection: conn, | ||
| }, | ||
| ) | ||
| func NewStorage(conn *sql.DB, dumper PgDump, t time.Duration) reader.Reader { |
vgarvardt
approved these changes
Mar 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow cancelation of long running queries