Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Version command #123

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Simplify Version command #123

merged 3 commits into from
Aug 14, 2020

Conversation

itsksaurabh
Copy link
Contributor

closes #122

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   42.72%   42.72%           
=======================================
  Files           8        8           
  Lines         316      316           
=======================================
  Hits          135      135           
  Misses        174      174           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce951ba...8d4e736. Read the comment docs.

@boekkooi-fresh
Copy link
Contributor

boekkooi-fresh commented Aug 14, 2020

👍 This replace the version command with the --version flags.
Because of the removal of the version command this is actually a BC break so let's include this in 0.3.0.

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@itsksaurabh
Copy link
Contributor Author

@boekkooi-fresh I am glad that you liked it. Awaiting merge. 😇

@vgarvardt
Copy link
Contributor

@itsksaurabh thank you for the contribution!

ldflags should be fixed as well, as version is injected in the compile-time https://github.com/hellofresh/klepto/blob/master/.goreleaser.yml#L13

@itsksaurabh
Copy link
Contributor Author

@vgarvardt I am glad that you liked it.

The version variable is already in the same cmd package just shifted to root.go in the same package.

So, I think it is not needed to change ldflags here.

Please let me know if I am missing something :)

@vgarvardt
Copy link
Contributor

@itsksaurabh true this, sorry

@vgarvardt vgarvardt merged commit 602add2 into hellofresh:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify Version command
3 participants