Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating deprecated command #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crosbymichael1
Copy link
Contributor

When running this script I get the following warning:

Flag --delete-local-data has been deprecated, This option is deprecated and will be deleted. Use --delete-emptydir-data.

Updating the command now before its completely removed

@crosbymichael1
Copy link
Contributor Author

@crhuber Can you please take a look at this one?

@crosbymichael1
Copy link
Contributor Author

@chadlwilson are you able to review this please?

@chadlwilson
Copy link
Contributor

chadlwilson commented Aug 13, 2022

I'm not a hellofresh person, so don't have ability to run workflows or merge.

It's probably OK to do this now, since it seems the new flag was introduced in kubectl 1.20.0, but have to keep in mind it will break the tool when used with older kubectls, and kubectl versions have to be kept a single version away from the kubernetes API server version.

EKS seem to still have Kubernetes 1.18 and 1.19 and technically kubectl 1.20 is not guaranteed to work on 1.18, however 1.18 ended EKS support in March 2022, and 1.19 recently, so I think this is probably OK. Not sure if they have started force-migrating clusters yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants