Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade bootstrap and bootswatch to 5.3.1 #310

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

PanderMusubi
Copy link
Collaborator

Fixing #308

@PanderMusubi
Copy link
Collaborator Author

Can you merge this one please?

When Bootswatch also has 5.3.2 I want to make another PR https://github.com/twbs/bootstrap/releases/tag/v5.3.2

A bit unrelated, I will also run another example website with the latest development version of Bootstrap-Flask.

@greyli greyli merged commit 02093bf into helloflask:master Sep 17, 2023
@greyli
Copy link
Member

greyli commented Sep 17, 2023

When Bootswatch also has 5.3.2 I want to make another PR twbs/[email protected] (release)

Merged, thanks!

I plan to remove the built-in JS/CCS resources in 3.0 (it's an unnecessary burden), and support customizing the CDN providers. This seems a better way to go. So I think we don't need to update these libraries.

@PanderMusubi
Copy link
Collaborator Author

I would like to propose that we still include it. I develop literally in planes, trains and automobiles and in countries where I have limited internet.

We could make it that by default the CDN is used for Bootstrap, Bootswatch, Bootstrap Icons, etc. but that there is also an option to use the version that we ship. I'm willing to upgrade tje JS/CSS we ship.

@PanderMusubi PanderMusubi deleted the bootstrap-531 branch September 18, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants