Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature of Bootstrap.__init__() incompatible with older version. #198

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

davidlesieur
Copy link
Contributor

The Bootstrap class is now a subclass of Bootstrap4, and provides a deprecation warning. That should prevent existing code from breaking. However, this purpose is defeated by a change in the signature of Bootstrap.__init__() that can break existing code.

This change restores the previous signature.

@davidlesieur
Copy link
Contributor Author

This matters for existing code that relies on the ability to pass the app object to the init_app() method instead of __init__().

@greyli greyli merged commit ff72e10 into helloflask:master Jan 27, 2022
@greyli
Copy link
Member

greyli commented Jan 27, 2022

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants