Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootswatch theme bug #141

Merged
merged 4 commits into from
Jun 12, 2021
Merged

Fix bootswatch theme bug #141

merged 4 commits into from
Jun 12, 2021

Conversation

yuxiaoy1
Copy link
Contributor

There is no bootswatch theme named 'default', thus it would lead to bugs if we use it per the docs.

@greyli
Copy link
Member

greyli commented Jun 12, 2021

Could you explain it in detail? I notice you deleted a theme file under the default folder, isn't the file for the default theme?

@yuxiaoy1
Copy link
Contributor Author

The issue is there is no CDN file for the default theme, you can check https://cdn.jsdelivr.net/npm/[email protected]/dist/default/bootstrap.min.css.
IMO, the correct way to set default theme is to disable the BOOTSTRAP_BOOTSWATCH_THEME configuration.

@greyli greyli merged commit 103b888 into helloflask:master Jun 12, 2021
@greyli
Copy link
Member

greyli commented Jun 12, 2021

I see, thanks!

@yuxiaoy1 yuxiaoy1 deleted the bootswatch branch June 12, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuxiaoy1 @greyli