Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix csrf token label of render field macro #131

Merged
merged 2 commits into from
May 18, 2021
Merged

Fix csrf token label of render field macro #131

merged 2 commits into from
May 18, 2021

Conversation

yuxiaoy1
Copy link
Contributor

Fix #127

@codecov-commenter
Copy link

Codecov Report

Merging #131 (d08f8a7) into master (0fc18ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   94.36%   94.36%           
=======================================
  Files           1        1           
  Lines          71       71           
  Branches       13       13           
=======================================
  Hits           67       67           
  Misses          1        1           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fc18ce...d08f8a7. Read the comment docs.

@caffeinatedMike
Copy link
Contributor

caffeinatedMike commented May 17, 2021

@yuxiaoy1 This will not fix the linked issue. Your logic only handles CSRFTokenFields, not HiddenFields. However, if you change it to

{%- elif field.type in ('CSRFTokenField', 'HiddenField') -%}

I believe that will cover it.

@yuxiaoy1
Copy link
Contributor Author

Good catch!
I just pushed a new commit to cover it.

@greyli greyli merged commit a6f8256 into helloflask:master May 18, 2021
@greyli
Copy link
Member

greyli commented May 18, 2021

@caffeinatedMike @yuxiaoy1 Merged, thanks!

@yuxiaoy1 yuxiaoy1 deleted the render-field-macro branch May 18, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] render_field macro leaving hidden field labels visible
4 participants