Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests #125

Merged
merged 5 commits into from
Apr 21, 2021
Merged

Improve tests #125

merged 5 commits into from
Apr 21, 2021

Conversation

Demetriex
Copy link
Contributor

Organize test so its easier to add tests in the future

@Demetriex
Copy link
Contributor Author

https://github.com/greyli/bootstrap-flask/blob/21853a9b38a68ad0b9bb402365617d3402fecb47/flask_bootstrap/__init__.py#L98-L99

We should also add test when with_jquery and with_popper args are false

@greyli
Copy link
Member

greyli commented Apr 20, 2021

Thank you very much! I think move the tests inside the macros folder to the root of the tests folder would be better.

greyli
greyli reviewed Apr 20, 2021
View reviewed changes
tests/test_themes.py Outdated Show resolved Hide resolved
@greyli greyli merged commit e3d5e50 into helloflask:master Apr 21, 2021
@greyli
Copy link
Member

greyli commented Apr 21, 2021

Merged, thanks!

@Demetriex Demetriex deleted the improve-test branch April 21, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyli greyli greyli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Demetriex @greyli