Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove playsound #352

Merged

Conversation

aliberts
Copy link
Contributor

@aliberts aliberts commented Sep 4, 2024

What this does

This removes the playsound package dependency as it is not used and is causing issues when trying to install stretch_body (see TaylorSMarks/playsound#143 and TaylorSMarks/playsound#145). Additionally, it is not maintained anymore.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@hello-binit hello-binit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awsome, thank you @aliberts!

@hello-binit hello-binit merged commit 96c5d5f into hello-robot:master Sep 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants