Fix failed compilation with --no-default-features
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, clippy is unhappy about the situation since it wants me to use |
alexrutar
force-pushed
the
fix-no-default-features-compilation
branch
2 times, most recently
from
447cd60 to
b2e1068
Compare
|
Ypu can use cfg-attr on the default attribute to appease clippy |
alexrutar
force-pushed
the
fix-no-default-features-compilation
branch
from
b2e1068 to
c00fdf2
Compare
alexrutar
changed the title
Default to fix failed compilation with --no-default-features--no-default-features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
nucleo_matcherdoes not compile with--no-default-featuresbecause the default values for some enums do not exist with--no-default-features. It is quite surprising to me that this has not been caught before!I couldn't figure out how to make attribute macros work with conditional compilation so I just wrote out the implementations manually.
It seems that this is not caught in CI because of a cargo bug (maybe rust-lang/cargo#7160 ?) so I guess CI should be fixed too. I don't want to touch the CI file myself though. I had to run
to get the error message. Maybe there is a better way to do this.