Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent shell_keep_pipe from stopping on nonzero exit status code #9817

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Prevent shell_keep_pipe from stopping on nonzero exit status code #9817

merged 1 commit into from
Mar 19, 2024

Conversation

sirius94
Copy link
Contributor

@sirius94 sirius94 commented Mar 5, 2024

The shell_impl and shell_impl_async functions no longer return success because it was always true. If the command didn't succeed both functions would return an Err.

This was also the reason, why shell_keep_pipe didn't work. It relied upon the value of success and aborted in case of an Err. It now removes any selection for which shell_impl returns Err.

If the command always fails, the selections are preserved and an error message is displayed in the status bar.

(shell_keep_pipe can be tested using the $ keybinding and grep for example)

@sirius94
Prevent shell_keep_pipe from stopping on nonzero exit status code
2301662 
The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
@the-mikedavis the-mikedavis added A-command Area: Commands S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 5, 2024
@archseer archseer requested a review from the-mikedavis March 19, 2024 05:40
the-mikedavis
the-mikedavis approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch about success being unused / always true. Thanks!

@the-mikedavis the-mikedavis merged commit 5b8bfc5 into helix-editor:master Mar 19, 2024
6 checks passed
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
@sirius94 @Desdaemon
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
f988f32 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@sirius94 @postsolar
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
961dd99 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@sirius94 @postsolar
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
6041aab 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@sirius94 @postsolar
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
b9089ed 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@sirius94 @postsolar
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
d775bfa 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@sirius94 @mtoohey31
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
63f1d62 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@sirius94 @Vulpesx
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
75d7b75 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@sirius94
Prevent shell_keep_pipe from stopping on nonzero exit status code (h…
cf51568 
…elix-editor#9817)

The `shell_impl` and `shell_impl_async` functions no longer return
`success` because it was always `true`. If the command didn't succeed
both functions would return an `Err`.

This was also the reason, why `shell_keep_pipe` didn't work. It relied
upon the value of `success` and aborted in case of an `Err`.
It now removes any selection for which `shell_impl` returns `Err`.

If the command always fails, the selections are preserved and an error
message is displayed in the status bar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
A-command Area: Commands S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirius94 @archseer @the-mikedavis