-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set soft-wrap enabled by default in markdown files #9018
Conversation
What is the behavior of overrides with the language setting? If this is set to true by default for markdown, and you toggle the global option off, what wins? I'd still like to be able to toggle it off at runtime. |
Just tried it out locally. I can confirm that the language setting always wins. And it goes both ways: even if you set it to false in your own This seems like a broader issue that's tangential to this PR, but I'd consider it a blocker for this, unfortunately. |
The language overwrite wins so this indeed removes the possibility of a runtime toggle. Stuff like this is what I would like to address with the scope system in #8853 |
Ah, thanks Pascal, somehow that issue flew under my radar. I'll take a read through it when I get some time. |
Glad you catched the misbehaviour! I think we can close this, since it's a simple PR, and discuss the config overhaul. |
Just to expand: You would be able to set config in different scipes lik in kakoune so you could do:
Each lf these scope are essentially their own full comfig (with the same inheritance rules as we have currently) so even all the first 3 options could be used to disable softwrap for markdown with this PR merged (last option is the same the current set does, the second last option would overwrite the setting for the current buffer and the first two would change the language settings) |
Yeah let's close this out for now pending the config changes in #8853 |
closes #8331