Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pylsp instead of pyls #834

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Using pylsp instead of pyls #834

merged 1 commit into from
Oct 13, 2021

Conversation

WindSoilder
Copy link
Contributor

Hi, firstly thanks for your awesome work :-D

I'm starting to try this new editor today, and find out the language server doesn't work for python project.

After investigate python language server, I find out this issue: palantir/python-language-server#935 It seems that the original pyls is unmaintained, we need to use new pylsp.

I don't know if merely change languages.toml to using pylsp is enough, but it works fine for me. Hope it can help.

@kirawi
Copy link
Member

kirawi commented Oct 13, 2021

Would it be better to change to https://github.com/microsoft/python-language-server?

@archseer
Copy link
Member

"pyls_ms has been abandoned by microsoft in favor of the proprietary pylance/the less featureful (but open-source) pyright" neovim/nvim-lspconfig#1074

So I think pylsp is the best.

@archseer archseer merged commit b42ef0e into helix-editor:master Oct 13, 2021
@fastfading
Copy link

pyright is definitely better , in syntax analysis , at least give user a choice

@archseer
Copy link
Member

There is only one default but you can always use a custom languages.toml configuration to switch to pyright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants