Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-enable haskell syntax #823

Closed
wants to merge 2 commits into from

Conversation

billksun
Copy link

Updated tree-sitter-haskell to tree-sitter/tree-sitter-haskell@bf7d643, and everything compiled. Also verified that syntax highlighting for Haskell is working on NixOS.

@archseer
Copy link
Member

The problem was cross compilation to aarch64. I don't think that's easily solvable unless cargo-cross is updated to a newer GCC version. tree-sitter/tree-sitter-haskell#34 (comment)

@billksun
Copy link
Author

Yeah, they have new instructions for building on MacOS: https://github.com/tree-sitter/tree-sitter-haskell#building-on-macos

From tree-sitter/tree-sitter-haskell#46

@archseer
Copy link
Member

Yeah, I had it building on macOS on CI previously. The issue is getting aarch64-linux to compile.

@archseer
Copy link
Member

@archseer
Copy link
Member

With

let flag = if build.get_compiler().is_like_msvc() {
"/std:c++17"
} else {
"-std=c++14"
};
it compiled on macOS

@billksun
Copy link
Author

From the last 2 comments here, tree-sitter/tree-sitter-haskell#34 (comment), it seems like using the Homebrew GCC from a M1 Mac will get you the correct version of GCC. But I see what you are saying now, we need the cross-compiler support to be on the right version as well.

@archseer
Copy link
Member

It might be okay to disable aarch64-linux builds altogether and disable cross compilation. Not sure how popular these builds are.

@billksun billksun closed this Dec 22, 2021
@billksun billksun deleted the feat/re-enable-haskell branch December 22, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants