Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove path completions for :new command #8010

Merged

Conversation

nkitsaini
Copy link
Contributor

@nkitsaini nkitsaini commented Aug 20, 2023

Since the argument of :new is never used, the completion might be confusing for user.

@nkitsaini nkitsaini force-pushed the read-arg-for-new-command branch 2 times, most recently from bbb1a5d to 7b8effd Compare August 20, 2023 09:00
@nkitsaini nkitsaini marked this pull request as draft August 20, 2023 09:00
@pascalkuthe
Copy link
Member

The current behaviour is intentional, there was a previous PR (can't find it tight now) with the same change. :new is intended for creating a new scratch buffer. If you want to open a new buffer with a path use :open

@nkitsaini
Copy link
Contributor Author

nkitsaini commented Aug 20, 2023

@pascalkuthe That makes sense. In that case I'll revert this change but also remove the path completion that we get for :new.

@nkitsaini nkitsaini changed the title [feat] Allow creating new files with given file path [chore] Remove path completions for :new command Aug 20, 2023
@nkitsaini nkitsaini force-pushed the read-arg-for-new-command branch from 7b8effd to fe9aec4 Compare August 20, 2023 09:39
@nkitsaini nkitsaini marked this pull request as ready for review August 20, 2023 09:42
@the-mikedavis the-mikedavis changed the title [chore] Remove path completions for :new command Remove path completions for :new command Aug 20, 2023
@the-mikedavis the-mikedavis merged commit 2767459 into helix-editor:master Aug 20, 2023
dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants