Skip rendering gutters when gutter width exceeds view width #7821
Conversation
|
As I already mentioned in #7156 (comment) fixing this by just limiting the line number width is just a hack. You cos have a gutter with 20 spacers and a terminal width of 20 (the terminal width can even be 0). So instead of just limiting this setting the right way to fix this is ti perform bounds check before deciding to even draw gutter elements |
My apologies, I misunderstood as it just being an issue with The video showcased has 47 2023-08-04.16-35-57.mp4 |
| is_focused, | ||
| &mut line_decorations, | ||
| ); | ||
| let gutter_overflow = view.gutter_offset(doc) == 0; |
There was a problem hiding this comment.
Not sure if this is the right way to go about it or if gutter_offset should return an Option<u16> instead with None in case of overflow
the-mikedavis
changed the title
Closes #7154
Setting
gutters.line-numbers.min-widthto a value higher thanterminal_width * terminal_heightled to index out of bounds.My approach was to have the width of
LineNumbersbe capped at 90% of the viewport size. Everything works as expected until the threshold is reached, whenmin_widthis set to default value.2023-08-03.21-59-41.mp4