Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Ada language support #7791
Initial Ada language support #7791
Changes from 1 commit
cc584e3
338c517
c993d39
44a1817
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The captures here should be adjusted to the ones that Helix uses: https://docs.helix-editor.com/master/themes.html#syntax-highlighting
For example
@conditional
should become@keyword.control.conditional
,@number
should become@constant.numeric
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The captures here should follow tree-sitter's locals capture names:
@local.scope
,@local.reference
and@local.definition
https://tree-sitter.github.io/tree-sitter/syntax-highlighting#local-variablesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I don't think I know that much, or anything really, about Tree Sitter to do that properly. I need to do some reading and find some time to do it. Unless there is someone else willing to chip in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the textobjects docs, Helix has a different set of textobject captures than nvim: https://docs.helix-editor.com/master/guides/textobject.html