Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP: Use negotiated position encoding for workspace edits #7469

Merged
merged 1 commit into from
Jun 29, 2023
Merged

LSP: Use negotiated position encoding for workspace edits #7469

merged 1 commit into from
Jun 29, 2023

Conversation

the-mikedavis
Copy link
Member

Previously this was hard-coded to UTF-8 but we might have negotiated another position encoding.

@the-mikedavis
LSP: Use negotiated position encoding for workspace edits
cf63c7d 
Previously this was hard-coded to UTF-8 but we might have negotiated
another position encoding.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much A-language-server Area: Language server client S-waiting-on-review Status: Awaiting review from a maintainer. labels Jun 27, 2023
pascalkuthe
pascalkuthe approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@archseer archseer merged commit 4fab600 into master Jun 29, 2023
@archseer archseer deleted the lsp-use-offset-encoding-for-workspace-edits branch June 29, 2023 15:24
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@the-mikedavis @wes-adams
LSP: Use negotiated position encoding for workspace edits (helix-edit…
c117faf 
…or#7469)

Previously this was hard-coded to UTF-8 but we might have negotiated
another position encoding.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@the-mikedavis @mtoohey31
LSP: Use negotiated position encoding for workspace edits (helix-edit…
ba3911e 
…or#7469)

Previously this was hard-coded to UTF-8 but we might have negotiated
another position encoding.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@the-mikedavis
LSP: Use negotiated position encoding for workspace edits (helix-edit…
2036c65 
…or#7469)

Previously this was hard-coded to UTF-8 but we might have negotiated
another position encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-server Area: Language server client C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-mikedavis @pascalkuthe @archseer