-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme: port of Zed's OneDark and OneLight themes #7250
Theme: port of Zed's OneDark and OneLight themes #7250
Conversation
How different is it from the regular one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like light and dark are virtually the same except for the colors. Could they be refactored into one theme where the other inherits it (https://docs.helix-editor.com/master/themes.html#inheritance) and changes the palette? For example see the gruvbox themes
@the-mikedavis great idea! I'll refactor it, there is quite a bit of of overlap between the two. |
thanks for the suggestion @the-mikedavis , this cleaned up the light theme a lot. |
…ighlight on light theme
I'm sorry for writing in a closed PR, but @EricHenry I need to know what is that beautiful font you're using (probably in all screenshots, but I like how it looks the most in the first post) |
@gavlig hey I totally get it. Haha I like beautiful fonts myself. There are 2 fonts in the first post. The one marked Zed is from the zed editor. They built their own font (that I’m a big fan of too) called Zed Mono and Zed Sans. You can find them here: https://github.com/zed-industries/zed-fonts The other screenshot marked helix is my other favorite font and daily driver. Cascading Code. Also free: https://github.com/microsoft/cascadia-code |
Thank you, much appreciated! |
I am a big fan of Zed's
OneDark
theme variation so I ported it over to helix. Here are some screen shot comparisons.Zed
Helix:
edit: updated screenshots