Add command to extend to line start or end #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
requested changes
Sep 6, 2021
helix-term/src/commands.rs
Outdated
| let (view, doc) = current!(cx.editor); | ||
| let text = doc.text().slice(..); | ||
|
|
||
| let selection = doc.selection(view.id).clone().transform(|range| { | ||
| let line = range.cursor_line(text); | ||
| let pos = line_end_char_index(&text, line); | ||
|
|
||
| range.put_cursor(text, pos, doc.mode == Mode::Select) | ||
| range.put_cursor(text, pos, always_extend || doc.mode == Mode::Select) |
There was a problem hiding this comment.
I'd rather see this parameter called extend, then you can map to the new extend_ commands inside the keymap
helix/helix-term/src/keymap.rs
Line 577 in 918bde0
(So two sets of commands, one that always moves, one that always extends)
There was a problem hiding this comment.
Even better than a bool would be if we reused this enum:
helix/helix-core/src/movement.rs
Lines 21 to 25 in 3fda350
pbzweihander
force-pushed
the
extend-to-line-start-end
branch
from
918bde0 to
471de01
Compare
|
@archseer I've updated PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
goto_line_{start,end,end_newline}commands works asextendwhen in select mode. This PR addsextend_to_line_{start,end,end_newline}commands that always extend to regardless of current mode.