Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line number display for LSP goto pickers #6559

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

sillent
Copy link
Contributor

@sillent sillent commented Apr 2, 2023

Fix the #6558

@the-mikedavis the-mikedavis linked an issue Apr 2, 2023 that may be closed by this pull request
@the-mikedavis the-mikedavis changed the title Wrong line on goto_reference Fix line number display for LSP goto pickers Apr 3, 2023
@the-mikedavis the-mikedavis merged commit dd6e0cc into helix-editor:master Apr 3, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
Line numbers are 0-indexed in the LSP spec but 1-indexed for display
and jumping purposes in Helix.
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
Line numbers are 0-indexed in the LSP spec but 1-indexed for display
and jumping purposes in Helix.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Line numbers are 0-indexed in the LSP spec but 1-indexed for display
and jumping purposes in Helix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong line on goto_reference
2 participants