Prepare for 23.3 release #6488
Merged
Prepare for 23.3 release #6488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
added
C-bug
pascalkuthe
force-pushed
the
prepare_release
branch
2 times, most recently
from
4d14600 to
a9462e4
Compare
pascalkuthe
force-pushed
the
prepare_release
branch
from
a9462e4 to
ece76a3
Compare
the-mikedavis
previously approved these changes
Mar 31, 2023
pascalkuthe
force-pushed
the
prepare_release
branch
from
ece76a3 to
b371d84
Compare
the previous implementation used set_string_truncated. This is not only awkward with this kind of "streaming" string (and therefore lead to an inefficient and incorrect initial implementation) but that function also truncates strings of width 1 when there is only a single char available. The implementation here is performant, correct and also handles the single width case correctly.
The current implementation didn't reload the theme if no no theme was explicitly configured (so the default theme was used). This commit brings `refresh_theme` in line with the initialization code.
Utf-8 support has been around for a while as an unstable feature but utf-32 is fairly new. A bunch of LS (like rust-analyzer) added this in a pinch, but it's pretty broken right now. The performance overhead is not very large (still a lot better than utf-16). We can switch back once the ecosystem has matured.
pascalkuthe
force-pushed
the
prepare_release
branch
from
b371d84 to
29fab3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a kitchen sink for all outstanding bug fixes left on the milestone.
Closes #6482
Closes #6346
Closes #3821
Closes #6467
Closes #6483
primarly gitoxide (plus cargo update) since depandabot missed it. Includes some fixes for bugs that affect helix on Windows (fix $HOME detection on windows GitoxideLabs/gitoxide#800 in particular)
editor.lsp.show-snippet-completions)fixes the issues with Allow truncation of table row text #6410 I found
small bug I found while testing this PR
Includes some style nits and conflict resolution
I can't reproduce this but from the logs it seems like RA crashing and somehow freezing helix in the process. I have already observed that the utf-32 option is implemented incorrectly in the few LSPs that support it (including RA) while the utf-8 extension has been around for a while and is much more stable.
Commits are best reviewed separately. Most of the diff are the Cargo.lock changes from running
cargo update