Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show current language when no argument is provided #5895

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Show current language when no argument is provided #5895

merged 1 commit into from
Feb 16, 2023

Conversation

LEI
Copy link
Contributor

@LEI LEI commented Feb 9, 2023

The command :set-language and :lang now behaves like :theme, as mentioned here.

  • Should the default value "text" be used, like in the statusline, maybe define a constant?
  • I expected :language to work, is there any reason against adding it as an alias?

@the-mikedavis the-mikedavis added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 10, 2023
the-mikedavis
the-mikedavis requested changes Feb 10, 2023
View reviewed changes
helix-term/src/commands/typed.rs Outdated Show resolved Hide resolved
@the-mikedavis the-mikedavis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 10, 2023
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2023
@archseer archseer merged commit 78a1e2d into helix-editor:master Feb 16, 2023
@LEI LEI deleted the show-lang branch February 16, 2023 16:20
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
@wes-adams
feat: show current language when no argument is provided (helix-edito…
452df7d 
…r#5895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@archseer archseer Awaiting requested review from archseer

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LEI @the-mikedavis @archseer