Prevent completion menu after navigation in insert mode #5803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poliorcetics
reviewed
Feb 5, 2023
pascalkuthe
added
A-helix-term
5 tasks
|
I just wanted to kindly follow up on my pull request and mention that I've been using it for the past 2 months and the modification has made the completion natural and instinctive. Is there anything else I can do to help move the process along? |
Merged
|
Yes please merge, it solves very annoying issue corrupting my code all the time |
|
we won't merge adhoc fixes like this. We are working on revamping thway completions are triggered more generally: #6910 (comment) |
Merged
p1gp1g
force-pushed
the
prevent_completion_navigation
branch
from
6053b56 to
8d9b92f
Compare
|
I have rebased the branch, for users using that patch. I don't know if it could be merged until the revamping is done (then reverted) ? |
|
This is fixed by #8021 which is a pretty high priority now. I don't see us merging another solution before that PR |
|
I see, I should test that PR then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #4144 , after the comment from @the-mikedavis :
Related issues: #2027 #2581.
The auto-completion menu now pops if you are in insert mode AND you have inserted something, as soon as you move again or do a ^C, you need to insert something again. This behavior is similar to what other IDE do (like Android Studio)