Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry up rendering code #5769

Closed

Conversation

theteachr
Copy link
Contributor

Cleans up the duplication that was introduced by #5318.

@theteachr theteachr marked this pull request as draft February 1, 2023 16:51
@theteachr theteachr force-pushed the remove-duplication-statusline branch from 7c54b80 to 1ca353d Compare February 1, 2023 16:54
@theteachr theteachr marked this pull request as ready for review February 1, 2023 17:06
@CBenoit CBenoit added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 2, 2023
@theteachr
Copy link
Contributor Author

Is render_buffer_title a better name?

@the-mikedavis
Copy link
Member

I still like render_path. I don't see the file path as the title of the buffer (I'm probably biased from the implementation 😅)

Actually we might want to take #4731 instead of this: separating the file modification indicator into its own element reduces the duplication between these two statusline elements and fixes some UI issues

@theteachr
Copy link
Contributor Author

theteachr commented Feb 8, 2023

separating the file modification indicator into its own element

I was planning to work on this next (thanks for the heads up on #4731), as my first priority was to remove the duplication I'd caused.

@theteachr theteachr force-pushed the remove-duplication-statusline branch from 6ca269b to ca997d3 Compare February 12, 2023 11:36
@theteachr theteachr closed this Mar 12, 2023
@theteachr theteachr deleted the remove-duplication-statusline branch March 12, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants