Switch from toml::from_slice to toml::from_str #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalkuthe
force-pushed
the
toml_update
branch
from
1ee1d3b to
ed6f9ef
Compare
pascalkuthe
added
E-easy
the-mikedavis
approved these changes
Jan 24, 2023
the-mikedavis
changed the title
|
no Or does |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks #5656
Just a small fix since that function was removed.
I found the usage of
std::fs::readinstead ofstd::fs::read_to_stringodd anyway.Sadly there is no
include_str!macro so we have the conversion ourselves (not a big deal regardless).