Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markup.strikethrough theme keys #5619

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Add markup.strikethrough theme keys #5619

merged 1 commit into from
Jan 21, 2023

Conversation

CptPotato
Copy link
Contributor

@CptPotato CptPotato commented Jan 21, 2023 •
edited
Loading

This PR adds markup.strikethrough to all themes that specify markup.italic/markup.bold.

I tried to adhere to the themes where possible ("/' quotes, key order and comments).

closes #5595

@CptPotato
Copy link
Contributor Author

CptPotato commented Jan 21, 2023 •
edited
Loading

Can anyone give this a spin?

The crossed_out modifier first worked when I tried it, but for whatever reason it doesn't on my machine. I might have messed up my helix grammars, as multiple markdown styles (bold, italic, inline code, etc.) are missing.

Edit: nevermind, looks like I was missing the markdown_inline grammar.

@CptPotato CptPotato force-pushed the markup-strikethrough branch from 27f7091 to 0ed8119 Compare January 21, 2023 09:28
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 21, 2023
@CptPotato CptPotato force-pushed the markup-strikethrough branch from 0ed8119 to 20702a7 Compare January 21, 2023 21:51
@the-mikedavis the-mikedavis merged commit f103d22 into helix-editor:master Jan 21, 2023
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
@CptPotato
Add markup.strikethrough theme keys (helix-editor#5619)
61a170e
@the-mikedavis the-mikedavis mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramojus ramojus ramojus left review comments

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify markup.strikethrough in themes
3 participants
@CptPotato @the-mikedavis @ramojus