-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove apply_transaction helper #5598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I forgot about this TODO: we removed the need for the apply_transaction
helper a while ago but didn't want to complicate the diff. I think we're safe to remove it now 👍
There's one more reference of it in the integration test suite helpers to be removed
I can't find it with |
Ah actually looks like there's two of them helix/helix-term/tests/test/helpers.rs Line 133 in edd0ba7
helix/helix-term/tests/test/helpers.rs Line 318 in edd0ba7
|
Oh, looks like I accidentally added |
d134bec
to
0188617
Compare
0188617
to
9340e08
Compare
Thanks for cleaning this up! |
Not sure why there is this TODO, so I cleaned it up.