-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rosé Pine theme: use official variants #5489
Rosé Pine theme: use official variants #5489
Conversation
After running
Will update these asap :) |
Lint errors have been fixed for |
For those you can ignore the errors: I would prefer that they use |
Sorry, slight conflict now since a previous PR changed the diagnostics to use curly underlines. Thank you for maintaining these now officially upstream! |
I like how this PR will ensure that the new curl underlines that I applied to only the normal variant will also work for the other variants 👍🏻 |
Thanks to the lovely community, we noticed our themes were included in Helix very early on. This PR updates the variants to match our current spec and palette.
We hope contributors make a PR at https://github.com/rose-pine/helix for any theme changes but understand this may not always be the case. For that reason, our Moon and Dawn variants inherit from the Main variant to try and keep them in sync as much as possible.
Please let me know if anything else is needed, and thank you 💜