Expand ~ when parsing file paths in :open
#5329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
A-helix-term
helix-term/src/args.rs
Outdated
| let def = || (PathBuf::from(s), Position::default()); | ||
| let def = || { | ||
| ( | ||
| helix_core::path::expand_tilde(Path::new(s)), |
There was a problem hiding this comment.
I think it would be better to call this from open in helix-term/src/commands/typed.rs. We don't need to do this for files passed in the argv since the shell will do the tilde expansion and there's a small bug here where :open fails if you give it a directory that has a tilde and a row or row/col position (though that isn't a use-case that makes sense)
the-mikedavis
approved these changes
Dec 29, 2022
the-mikedavis
changed the title
~ when parsing file paths~ when parsing file paths in :open
mejo13
pushed a commit
to mejo13/helix
that referenced
this pull request
Dec 29, 2022
semin-park
pushed a commit
to semin-park/helix
that referenced
this pull request
Jan 4, 2023
hadronized
pushed a commit
to hadronized/helix
that referenced
this pull request
Jan 4, 2023
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5322.
Expected
:openshould work on directories with~in the filepath (i.e. file picker dialog opens)helix1fix.mov