Add shift-backspace keybind alias for backspace #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By default the terminal can't tell the difference between backspace and S-backspace: all of these commands already work with S-backspace. Terminals that implement the progressive keyboard enhancement protocol can tell the difference but we need to detect and enable that from within Helix. See the |
lesleyrs
changed the base branch from
master
to
enable-keycode-disambiguation
|
Ok sounds good, I'm not sure how to have 2 separate helix installs work so I can't test if I did it correctly. And I don't wanna mess with my current install. |
|
Just FYI enable key code disambiguation was just merged also you can do |
the-mikedavis
force-pushed
the
enable-keycode-disambiguation
branch
from
b31b320 to
a57e5ed
Compare
|
#4887 handles the new keys but doesn't enable the disambiguation flags. See #4887 (comment) |
|
Oh right sorry about that. |
kirawi
added
A-keymap
|
Misclick. |
|
Ok I just did a cargo run and it seems to work as intended in both editor and prompt 👍. Thx for the help guys! |
the-mikedavis
changed the title
the-mikedavis
pushed a commit
that referenced
this pull request
Jan 11, 2023
the-mikedavis
pushed a commit
that referenced
this pull request
Feb 8, 2023
the-mikedavis
pushed a commit
that referenced
this pull request
Feb 11, 2023
When the Kitty Keyboard Protocol is enabled, S-backspace is distinguished from backspace with no modifiers. This is awkward when typing because it's very easy to accidentally hold shift and press backspace temporarily when typing capital letters. Kakoune (which is also a Kitty Keyboard Protocol application) treats S-backspace as backspace too: https://github.com/mawww/kakoune/blob/3150e9b3cd8e61d9bc68245d67822614d4376cf4/src/input_handler.cc#L1275
the-mikedavis
pushed a commit
that referenced
this pull request
Feb 26, 2023
When the Kitty Keyboard Protocol is enabled, S-backspace is distinguished from backspace with no modifiers. This is awkward when typing because it's very easy to accidentally hold shift and press backspace temporarily when typing capital letters. Kakoune (which is also a Kitty Keyboard Protocol application) treats S-backspace as backspace too: https://github.com/mawww/kakoune/blob/3150e9b3cd8e61d9bc68245d67822614d4376cf4/src/input_handler.cc#L1275
the-mikedavis
pushed a commit
that referenced
this pull request
Feb 26, 2023
When the Kitty Keyboard Protocol is enabled, S-backspace is distinguished from backspace with no modifiers. This is awkward when typing because it's very easy to accidentally hold shift and press backspace temporarily when typing capital letters. Kakoune (which is also a Kitty Keyboard Protocol application) treats S-backspace as backspace too: https://github.com/mawww/kakoune/blob/3150e9b3cd8e61d9bc68245d67822614d4376cf4/src/input_handler.cc#L1275
archseer
pushed a commit
that referenced
this pull request
Feb 28, 2023
When the Kitty Keyboard Protocol is enabled, S-backspace is distinguished from backspace with no modifiers. This is awkward when typing because it's very easy to accidentally hold shift and press backspace temporarily when typing capital letters. Kakoune (which is also a Kitty Keyboard Protocol application) treats S-backspace as backspace too: https://github.com/mawww/kakoune/blob/3150e9b3cd8e61d9bc68245d67822614d4376cf4/src/input_handler.cc#L1275
estin
pushed a commit
to estin/helix
that referenced
this pull request
Mar 4, 2023
When the Kitty Keyboard Protocol is enabled, S-backspace is distinguished from backspace with no modifiers. This is awkward when typing because it's very easy to accidentally hold shift and press backspace temporarily when typing capital letters. Kakoune (which is also a Kitty Keyboard Protocol application) treats S-backspace as backspace too: https://github.com/mawww/kakoune/blob/3150e9b3cd8e61d9bc68245d67822614d4376cf4/src/input_handler.cc#L1275
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
When the Kitty Keyboard Protocol is enabled, S-backspace is distinguished from backspace with no modifiers. This is awkward when typing because it's very easy to accidentally hold shift and press backspace temporarily when typing capital letters. Kakoune (which is also a Kitty Keyboard Protocol application) treats S-backspace as backspace too: https://github.com/mawww/kakoune/blob/3150e9b3cd8e61d9bc68245d67822614d4376cf4/src/input_handler.cc#L1275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this PR works but would be nice to have, no real reason not to I guess?