Run clippy on workspace in CI #4614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like |
xJonathanLEI
force-pushed
the
dev/clippy
branch
from
210f150 to
b0c8076
Compare
|
Ah never realized it's deprecated since there's no depreciation warning. Fixed now. Thanks! |
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CI runs clippy as
cargo clippy --all-targetswithout the--allflag, causing some code to be ignored. This PR enforces the--allflag and resolves some warnings from the addition of the flag.