update x_offset calculation in Buffer::set_string_truncated
#3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when `truncate_start` is `true`, the `x_offset` is now properly updated according to the width of the content or the truncated length.
CBenoit
added
S-waiting-on-review
kristopherbullinger
force-pushed
the
master
branch
from
28377c3 to
9b9cf88
Compare
There was a problem hiding this comment.
Seems like a good thing to add a test case for.
I like the name change, it matches:
helix/helix-term/src/ui/text.rs
Line 58 in b5be72b
archseer
approved these changes
Nov 17, 2022
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
…editor#3839) when `truncate_start` is `true`, the `x_offset` is now properly updated according to the width of the content or the truncated length.
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
…editor#3839) when `truncate_start` is `true`, the `x_offset` is now properly updated according to the width of the content or the truncated length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. First time contributor here.
SUMMARY:
With these changes, when
truncate_startistruein a call toBuffer::set_string_truncated, thex_offsetis now properly updated according to the (potentially truncated) content width.Previously, the
x_offsetwas never updated in this branch of code, which caused a layout error when rendering a Picker with items whose calculated labels contained multiple Spans. Sincex_offsetwas not updated between calls toset_string_truncated, each span's content would render starting from the leftmost edge of the item's line, causing the content items to overlap each other. For example, in a menu item with two spans with contentsome_directory/and14.5 KB, it would render as14.5 KBrectory/.Also, I took the liberty of renaming a variable for added clarity.