Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: boo_berry #3574

Closed

Conversation

AlexanderBrevig
Copy link
Contributor

passes linter from #3234
image

@AlexanderBrevig
Copy link
Contributor Author

@bootradev please sanity check my choices :)

@Omnikar
Copy link
Contributor

Omnikar commented Aug 27, 2022

Is opening one PR for every one of the themes really necessary?

@AlexanderBrevig
Copy link
Contributor Author

I wanted a way to get a follow up from each author. It would be pretty crowded in a "one PR to rule them all" situation.

But I can make a big PR if that is preferred.

@Omnikar
Copy link
Contributor

Omnikar commented Aug 27, 2022

Hm, I'm not sure.

@AlexanderBrevig
Copy link
Contributor Author

Oh well. It's done now. Worked all night on this, and finally now I can actually choose a random Helix theme and actually get work done with it :)

I will apologize in the Matrix chat for the noise it stirred up.

@bootradev
Copy link
Contributor

What does it look like when the cursor is on a line with text on it?

@AlexanderBrevig
Copy link
Contributor Author

it collided with selection, maybe going a slight tad up in brightness is better?
image

@bootradev
Copy link
Contributor

Sure, have berry_dim be #47345E

@AlexanderBrevig
Copy link
Contributor Author

Moved to bulk PR #3587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants