Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add syntax highlights for xit #3521

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Conversation

ChemicalXandco
Copy link
Contributor

@ChemicalXandco ChemicalXandco commented Aug 23, 2022

xit (specification) is a plain-text file format for todos and check lists.

Currently tags and dates are not supported in the tree sitter grammar implementation.

Default theme:
image

dark_plus:
image

Comment on lines 6 to 9
(obsolete_checkbox) @hint

(checked_task) @hint
(obsolete_task) @hint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with xit but @comment.unused might be a good scope for these. That scope is usually used for languages with pattern matching where a variable is underscored when it's unused:

{_x, y} = {100, 50}
y * 2

What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, you are right, I have amended the changes

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll have to give xit a try myself :)

@the-mikedavis the-mikedavis merged commit 6b912b8 into helix-editor:master Aug 24, 2022
AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants