Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cue support #3262

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Conversation

b4nst
Copy link
Contributor

@b4nst b4nst commented Jul 30, 2022

This PR add support for CUE using dagger/cuelsp and eonpatapon/tree-sitter-cue.

I'm wondering if it's there's a way to give the format command another command than the lsp (cue fmt)?
It's not a big caveheat since dagger/cuelsp#44 should resolve that anyway.

@the-mikedavis
Copy link
Member

Can you adjust the scopes here to match the ones we use in helix? https://docs.helix-editor.com/master/themes.html#syntax-highlighting

For example, we don't use @repeat or @number

@b4nst b4nst force-pushed the feat/add-cue-support branch from 7a6f654 to 7140214 Compare July 30, 2022 22:22
@b4nst
Copy link
Contributor Author

b4nst commented Jul 30, 2022

@the-mikedavis sorry I didn't realise it was not neovim compatible scopes. Should be better now (and indeed that looks way better 🤦)

@b4nst b4nst force-pushed the feat/add-cue-support branch from 7140214 to d7eb9b3 Compare July 30, 2022 22:26
@archseer archseer requested a review from the-mikedavis July 31, 2022 08:07
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@the-mikedavis the-mikedavis merged commit 7e06681 into helix-editor:master Jul 31, 2022
GreasySlug pushed a commit to GreasySlug/helix that referenced this pull request Aug 2, 2022
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
jzelinskie added a commit to jzelinskie/helix that referenced this pull request Jan 25, 2023
cuelsp does not support formatting.
Cue language support was added to Helix before
"formatter" was available.

References:
helix-editor#3262
dagger/cuelsp#44
the-mikedavis pushed a commit that referenced this pull request Jan 25, 2023
cuelsp does not support formatting.
Cue language support was added to Helix before
"formatter" was available.

References:
#3262
dagger/cuelsp#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants