-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gutters padding automatic #3163
Conversation
helix-view/src/editor.rs
Outdated
@@ -332,8 +332,6 @@ pub enum GutterType { | |||
Diagnostics, | |||
/// Show line numbers | |||
LineNumbers, | |||
/// Show one blank space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the element because it's still useful if you want to add padding between diagnostics and line number for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I add it back then it no longer fix the issue, I think probably a separate fix is needed, but for now I think it is fine.
Remove padding gutter type, and automatically add 1 padding if gutters is non-empty.
c155990
to
eed5fea
Compare
It doesn't solve my issue, the padding is still colored for me. Like the problem that it's not like padding isn't there, but that it's using gutters color, but before it was using a backround color. |
You forgot to remove the padding component from the default: https://github.com/helix-editor/helix/blob/dfc31e74af1b96d9097496f1faa38710ecd30580/helix-view/src/editor.rs#L476= |
Fixed in 255c173 |
Remove padding gutter type, and automatically add 1 padding if gutters is non-empty.
Remove padding gutter type, and automatically add 1 padding if gutters is
non-empty.
Fix #3111
cc @kchibisov hopefully this solves your issue
Sad to see a breaking change but it should be fine given that we haven't do a release yet