Exclude only named children without injection.include-children

[MDeiml]

This fixes problems arising in #3108.

The markdown parser needs to exclude children for language injection, but only named ones. This is different from the behavior in tree-sitter-highlight, but to me it seems more sensible.

To give a technical example: Otherwise there is almost no way to write something like

rule: $ => seq('(', repeat(choice($._content, $.excluded)), ')'),

where $._content and the parentheses should be included and $.excluded excluded. This is because there will always be '(' and ')' nodes as a child of rule.

[the-mikedavis]

If you want a node from the tree to be queryable, it should be named: that's the point of named nodes. I think you should restructure the grammar to expose the nodes you want to capture in queries.

I can't test this at the moment but I suspect this breaks injections for some templating languages or maybe Rust macros? I'll give it a look when I have a chance

[MDeiml]

If you want a node from the tree to be queryable, it should be named: that's the point of named nodes. I think you should restructure the grammar to expose the nodes you want to capture in queries.

That's my point. I expose inline nodes and block_continuation nodes. I want to capture the former while excluding the latter. I don't want to exclude unnamed nodes that I have less control over when writing the grammar.

Also notice how not excluding unnamed nodes is strictly more expressive. In a tree-sitter grammar an unnamed node can always be turned into a named one with alias(...). I think this is exactly what you meant?

I can't test this at the moment but I suspect this breaks injections for some templating languages or maybe Rust macros? I'll give it a look when I have a chance

I'm gonna have a look myself too. If that's the case and the queries can't easily be changed to work with the new behavior: how do you feel about adding a include-unnamed or exclude-named flag? I'm not sure it's possible to make my grammar work without this.

[MDeiml]

It seems you're right. Many languages rely on excluding unnamed nodes for injecting the comment language.

[the-mikedavis]

A separate property like include-unnamed sounds like a good addition to me 👍

[the-mikedavis]

This looks good, thanks for working on it 👍