Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SCSS language support #3074

Merged
merged 7 commits into from
Jul 17, 2022
Merged

Add SCSS language support #3074

merged 7 commits into from
Jul 17, 2022

Conversation

jharrilim
Copy link
Contributor

@jharrilim jharrilim commented Jul 15, 2022 •
edited
Loading

Adds SCSS language support:

  • Highlighting
  • Language server support

image

the-mikedavis
the-mikedavis reviewed Jul 15, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments but this looks good to me otherwise 👍

runtime/queries/scss/highlights.scm Outdated Show resolved Hide resolved
languages.toml Outdated Show resolved Hide resolved
@jharrilim jharrilim requested a review from the-mikedavis July 17, 2022 04:21
the-mikedavis
the-mikedavis approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@the-mikedavis the-mikedavis merged commit 0c9594e into helix-editor:master Jul 17, 2022
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@jharrilim @thomasskk
Add SCSS language support (helix-editor#3074)
58ee190
@David-Else
Copy link
Contributor

David-Else commented Oct 14, 2022 •
edited
Loading

@jharrilim Could you add install instructions at https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers ?

I assume it will be almost identical to https://github.com/helix-editor/helix/wiki/How-to-install-the-default-language-servers#cssls , but I would not want to presume that.

@jharrilim
Copy link
Contributor Author

Added the instructions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jharrilim @David-Else @the-mikedavis