-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse table widget in picker #3053
Reuse table widget in picker #3053
Conversation
7d53b58
to
4003241
Compare
4003241
to
88181d1
Compare
87ef666
to
9962bc8
Compare
The table column width calculation code has been updated to match the upstream implementation in the |
@sudormrfbin I'm working on a branch that aims to refine the keymap presentation in both the info boxes and the command palette. Wanted to see how the command palette could look with column formatting, so I've already started on an implementation for that hehe. I will post the draft during the week, only marking it as a PR once this one gets merged. Feel free to use the code in the commit in the meanwhile (also in case mine doesn't go through), I'll just make sure to omit the commit from my draft if you do :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as always!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(oops)
Arranges the document id, file flags (is-modified, is-current) and file path in a table leveraging helix-editor#3053.
Continues #2814. This change reuses the table widget directly in the picker, finally allowing items to be formatted as columns 🎉. Column formatting can be done by implementing
menu::Item::row()
on the picker items.Behavioral Changes
align
property on table cells.Bugs
Future Work
table::Cell