Goto mode implementation #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
commented
Oct 6, 2020
helix-view/src/commands.rs
Outdated
| pub fn move_file_end(view: &mut View, _count: usize) { | ||
| // TODO: use a transaction | ||
| let text = &view.state.doc; | ||
| let last_line = text.line_to_char(text.len_lines().checked_sub(2).unwrap()); |
helix-view/src/commands.rs
Outdated
| pub fn check_cursor_in_view(view: &mut View) -> bool { | ||
| let cursor = view.state.selection().cursor(); | ||
| let line = view.state.doc().char_to_line(cursor) as u16; | ||
| let document_end = view.first_line + view.size.1.saturating_sub(1) - 1; |
helix-view/src/commands.rs
Outdated
| view.first_line = view.first_line.saturating_sub(view.size.1); | ||
|
|
||
| view.state.selection = Selection::single( | ||
| text.line_to_char(view.first_line as usize), |
There was a problem hiding this comment.
Calculate line_to_char in all of these methods once by assigning it to let pos
helix-view/src/commands.rs
Outdated
| } | ||
|
|
||
| pub fn half_page_down(view: &mut View, _count: usize) { | ||
| view.first_line += view.size.1 / 2; |
There was a problem hiding this comment.
This needs to make sure first_line < text.len_lines(), pressing half_page_down/page_down at document end will crash. Use a similar approach last_line() uses to clamp the value.
helix-view/src/commands.rs
Outdated
| if !check_cursor_in_view(view) { | ||
| let text = &view.state.doc; | ||
| view.state.selection = Selection::single( | ||
| text.line_to_char(view.first_line as usize), |
There was a problem hiding this comment.
When scrolling down, you want the cursor to stick to the top edge (first_line + padding), when scrolling up you want it to be at the bottom of the screen last_line() - padding.
Make padding a const PADDING: u16 = 5 for now
humblehacker
added a commit
to humblehacker/helix
that referenced
this pull request
Jul 29, 2023
JeftavanderHorst
pushed a commit
to JeftavanderHorst/helix
that referenced
this pull request
Mar 10, 2024
add python context queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.