helix-term: ui: Refactor statusline rendering, set configurable #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Litchi Pi <[email protected]>
|
My bad, entered directly into the meat of the code and didn't check all the issue before, missed #2434 PR. Maybe it can bring a thing or 2 to the other PR (I do think the |
pickfire
reviewed
Jun 2, 2022
Comment on lines
-785
to
-797
| surface.set_string_truncated( | ||
| viewport.x + 8, // 8: 1 space + 3 char mode string + 1 space + 1 spinner + 1 space | ||
| viewport.y, | ||
| &title, | ||
| viewport | ||
| .width | ||
| .saturating_sub(6) | ||
| .saturating_sub(right_side_text.width() as u16 + 1) as usize, // "+ 1": a space between the title and the selection info | ||
| |_| base_style, | ||
| true, | ||
| true, | ||
| ); | ||
| } |
There was a problem hiding this comment.
I am worried if we do a custom statusline we lost the ability to do truncation.
pickfire
reviewed
Jun 2, 2022
| for element in self.statusline_middle.iter() { | ||
| element.render( | ||
| &mut middle_text, | ||
| &self, |
There was a problem hiding this comment.
I think you might have to fix the lints.
|
#2434 was merged, but thanks for looking into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to help bring custom statusline (related issue #708), I created a first refactor that changes almost nothing in the render but would allow future configuration of the statusline:
render_statuslinefunction, created aStatuslineRenderstruct instead.StatuslineElementenum to store every element that can be rendered, with configurable data associated.Every new "feature" to add to the statusline will just be a new element in this enum.
String(user config) toStatuslineRenderwill take placeStill have to decide the format and implement it.
I was thinking of something like:
{mode} blah blah {filename} bli blouh {diagnostic W E}"blah blah" being static strings added to the statusline, (spaces, dashes, dots, etc ...)
"W" and "E" being configurable data associated to the statusline element
Changes in the rendered UI:
Questions I have regarding the implementation:
structwell placed in the code ?renderfunctions in order to implement any further features on the bar ?EditorViewstruct can access the user configuration in order to load theStatuslineRenderstruct from the placeholder string ?First contribution here, please tell me if there's something wrong :-)