Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tree-sitter ssh client config queries #2498

Merged
merged 2 commits into from
May 18, 2022
Merged

Add tree-sitter ssh client config queries #2498

merged 2 commits into from
May 18, 2022

Conversation

midnightexigent
Copy link
Contributor

@midnightexigent midnightexigent commented May 18, 2022 •
edited
Loading

@midnightexigent midnightexigent mentioned this pull request May 18, 2022
Merged
@the-mikedavis
Copy link
Member

You can move the configuration in languages.toml over to this PR as well. The new language can be merged without #2455: it won't automatically highlight on ssh config files until that PR is merged but it would be possible to manually set the syntax :lang sshclientconfig in the meantime.

@midnightexigent midnightexigent force-pushed the sshclientconfig-syntax branch from b3a017a to a01e363 Compare May 18, 2022 18:18
@midnightexigent
Copy link
Contributor Author

Somehow forgot about that. Done

@the-mikedavis the-mikedavis self-requested a review May 18, 2022 18:23
the-mikedavis
the-mikedavis requested changes May 18, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit and then this looks good 👍

languages.toml Outdated Show resolved Hide resolved
@midnightexigent @the-mikedavis
Update languages.toml
a727f3c 
Co-authored-by: Michael Davis <[email protected]>
@the-mikedavis
Copy link
Member

The queries are a little verbose because the grammar has a lot of different nodes. I think it could be refactored to be a little cleaner - I might take a look at forking it at some point.

@the-mikedavis the-mikedavis merged commit 8493b5f into helix-editor:master May 18, 2022
@midnightexigent midnightexigent deleted the sshclientconfig-syntax branch May 18, 2022 21:31
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
@midnightexigent @the-mikedavis @mtoohey31
Add tree-sitter ssh client config queries (helix-editor#2498)
222298f 
Co-authored-by: Michael Davis <[email protected]>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
@midnightexigent @the-mikedavis @mtoohey31
Add tree-sitter ssh client config queries (helix-editor#2498)
8377281 
Co-authored-by: Michael Davis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@midnightexigent @the-mikedavis