-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(languages): add odin language #2399
feat(languages): add odin language #2399
Conversation
This commit adds the odin language by using the grammar and highlighting queries written by MineBill from github This commit resolves #2340 by just applying all the changes already discussed in the issue
|
If you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few suggested changes here to bring the captures in line with the ones helix uses: https://github.com/helix-editor/helix/blob/f1a77370cf679eb0f3a58cfb12deec8ff7fc6325/book/src/themes.md#syntax-highlighting
Hey, I just looked into your review. Sorry for adding the queries so carelessly. I think I understand the purpose of the file a bit better now. All of your suggested changes make sense. |
- mostly apply changes from review by the-mikedavis (thanks) extra changes listed below - change true/false to @constant.builtin.boolean - change comment to @comment.line
No worries, queries typically need a bit of tuning anyways 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Highlighting still isn't working for me, although it seems like Helix is recognizing |
Check out Lines 52 to 55 in 7b287f6
Would you like to submit a PR to change it? If Odin itself uses tabs it probably makes sense to set tabs as the default (and then it can be overridden on a per-project basis with #1249). |
Linking worked, thanks! Also opened a PR regarding tabs/spaces #2464. |
This commit adds the odin language by using the grammar and highlighting
queries written by MineBills repo.
This commit resolves #2340 by just applying all the changes already
discussed in the issue.