Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): add toml lsp #2302

Merged
merged 1 commit into from
Apr 27, 2022
Merged

feat(lsp): add toml lsp #2302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/src/generated/lang-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
| swift | ✓ | | | `sourcekit-lsp` |
| tablegen | ✓ | ✓ | ✓ | |
| tfvars | | | | `terraform-ls` |
| toml | ✓ | | | |
| toml | ✓ | | | `taplo` |
| tsq | ✓ | | | |
| tsx | ✓ | | | `typescript-language-server` |
| twig | ✓ | | | |
Expand Down
1 change: 1 addition & 0 deletions languages.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ injection-regex = "toml"
file-types = ["toml"]
roots = []
comment-token = "#"
language-server = { command = "taplo", args = ["lsp", "stdio"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the docs (here) it looks like this should be

Suggested change
language-server = { command = "taplo", args = ["lsp", "stdio"] }
language-server = { command = "taplo-lsp", args = ["run"] }

But maybe I'm just running an out of date binary locally? I'm running taplo-lsp 0.2.6 and maybe the most recent taplo has consolidated the LSP and CLI binaries?

Copy link
Contributor Author

@axdank axdank Apr 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

taplo-lsp can no longer be installed by itself, it can only be run from taplo lsp.
I think it was unified all in one.

https://taplo.tamasfe.dev/lsp/#native-binary
In this section it says install with cargo install taplo-lsp but throws an error.

image

I install taplo-cli and it runs with the simple taplo command. I attach a screenshot.

image

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, yeah looks like my package manager is behind on taplo versions. This looks good then 👍

indent = { tab-width = 2, unit = " " }

[[grammar]]
Expand Down