Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lsp): add yaml lsp #2234

Merged
merged 2 commits into from
Apr 23, 2022
Merged

feat(lsp): add yaml lsp #2234

merged 2 commits into from
Apr 23, 2022

Conversation

hown3d
Copy link

@hown3d hown3d commented Apr 23, 2022

add yaml-language server configuration in languages.toml

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@the-mikedavis the-mikedavis merged commit 1c1ba00 into helix-editor:master Apr 23, 2022
@hown3d hown3d deleted the yaml-lsp branch April 23, 2022 17:18
@David-Else
Copy link
Contributor

@hown3d Hi, thanks for adding this. I am having problems getting the formatting working, I have tried both the following but no luck:

[[language]]
name = "yaml"

# [language.config]
# yaml = { format.enable = true }

# config = { yaml.format.enable = true} 

It seems correct it is a boolean: https://github.com/search?q=yaml.format.enable&type=code

Have you any ideas? The language server is running OK. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants