Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autumn theme #2212

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Add autumn theme #2212

merged 2 commits into from
Apr 22, 2022

Conversation

getreu
Copy link
Contributor

@getreu getreu commented Apr 21, 2022

Screenshot:

autumn-screenshot

And discussion here: #727 (comment)

Feedback is welcome.

@the-mikedavis
Copy link
Member

There are some other scopes you'll want to theme as well:

  • ui.virtual.whitespace: visible whitespace characters (:set whitespace.render all if running on latest changes)
  • ui.virtual.ruler: the rulers (:set rulers [80], also merged after 22.03)

For both you'll probably want a color close to what gets used for comments but maybe dimmer/darker. For whitespace you'll probably want that configured as "ui.virtual.whitespace" = { fg = "that_color" } and for the ruler: "ui.virtual.ruler" = { bg = "that_color" }

@getreu
Copy link
Contributor Author

getreu commented Apr 22, 2022

@the-mikedavis I added a ruler colour a just a little lighter than the background, so that you can see it without effort, without becoming dominant. I chose the whithespace colour a little lighter than comments. Otherwise one would not see the little dot in the middle comfortably.

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

I love a warm color palette 🎨

@the-mikedavis
Copy link
Member

Could you please add a screenshot to the themes wiki https://github.com/helix-editor/helix/wiki/Themes?

@the-mikedavis the-mikedavis merged commit 3c250b7 into helix-editor:master Apr 22, 2022
@getreu
Copy link
Contributor Author

getreu commented Apr 22, 2022

Could you please add a screenshot to the themes wiki https://github.com/helix-editor/helix/wiki/Themes?

Done. See Theme: Autumn · helix-editor/helix Wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants